Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lampo backend interface re-thinking #181

Open
vincenzopalazzo opened this issue Jan 2, 2024 · 0 comments
Open

lampo backend interface re-thinking #181

vincenzopalazzo opened this issue Jan 2, 2024 · 0 comments
Assignees
Labels
❤️ - ldk Related to ldk code 🦀 - rust Rust related things help wanted Extra attention is needed P-hight Hiight Priotity issue

Comments

@vincenzopalazzo
Copy link
Owner

vincenzopalazzo commented Jan 2, 2024

I had a conversation with @tnull, (an expert in LDK and Lightning), who was kind enough to review my initial of lampo. It is a little bit hacky had buggy but I am not surprised by the code that I wrote on some hot London night in 2022.

The main issue is that the lampo-bitcoind has several bugs events that ldk can take in the wrong way. I need to think about potential solutions and all the bugs, and one possibility might be found here: https://docs.rs/lightning-transaction-sync/latest/lightning_transaction_sync/#usage-example.

I'm uncertain about how to handle the lampo-nakamoto backend. However, it's clear that incorporating lightning_transaction_sync is important for moving towards a well-tested solution and OFC the important part for me is that it is maintained by ldk people 😄. However, we'll need to consider if this allows us the same level of flexibility.

@vincenzopalazzo vincenzopalazzo added help wanted Extra attention is needed 🦀 - rust Rust related things ❤️ - ldk Related to ldk code labels Jan 2, 2024
@vincenzopalazzo vincenzopalazzo pinned this issue Jan 2, 2024
@vincenzopalazzo vincenzopalazzo added this to the v24.03 milestone Jan 2, 2024
@vincenzopalazzo vincenzopalazzo self-assigned this Jan 2, 2024
@vincenzopalazzo vincenzopalazzo added the P-hight Hiight Priotity issue label Jan 2, 2024
@vincenzopalazzo vincenzopalazzo modified the milestones: v24.03, v24.06 Mar 30, 2024
@vincenzopalazzo vincenzopalazzo removed this from the v24.06 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❤️ - ldk Related to ldk code 🦀 - rust Rust related things help wanted Extra attention is needed P-hight Hiight Priotity issue
Projects
Status: Todo
Development

No branches or pull requests

1 participant