We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component events extending CustomEvent, such as DatePickerValidatedEvent, don't specify a TypeScript type for the target property:
CustomEvent
DatePickerValidatedEvent
web-components/packages/date-time-picker/src/vaadin-date-time-picker.d.ts
Line 50 in 48089e8
The target property is only typed for ChangeEvent:
ChangeEvent
Lines 33 to 35 in 48089e8
As a result, for custom events, the target has to be manually cast to the component type to access component properties in the listener:
Specify the component type as the type for the target property in all component events to save developers from tedious manual casting.
No response
change
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe your motivation
Component events extending
CustomEvent
, such asDatePickerValidatedEvent
, don't specify a TypeScript type for the target property:web-components/packages/date-time-picker/src/vaadin-date-time-picker.d.ts
Line 50 in 48089e8
The target property is only typed for
ChangeEvent
:web-components/packages/date-time-picker/src/vaadin-date-time-picker.d.ts
Lines 33 to 35 in 48089e8
As a result, for custom events, the target has to be manually cast to the component type to access component properties in the listener:
Describe the solution you'd like
Specify the component type as the type for the target property in all component events to save developers from tedious manual casting.
Describe alternatives you've considered
No response
Additional context
change
event [⏳ 1d] #3040The text was updated successfully, but these errors were encountered: