Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seq: fails to parse hexadecimal floating-point arguments like 0x1p-1 #6935

Open
aimerlief opened this issue Dec 7, 2024 · 5 comments
Open

seq: fails to parse hexadecimal floating-point arguments like 0x1p-1 #6935

aimerlief opened this issue Dec 7, 2024 · 5 comments
Labels
U - seq

Comments

@aimerlief
Copy link
Contributor

While running bash util/run-gnu-test.sh, I encountered a bug where seq fails to handle hexadecimal arguments correctly. Specifically, the following command does not behave as expected:

$ cargo run -q seq 0x1p-1 2
seq: invalid hexadecimal argument: '0x1p-1'
$ seq 0x1p-1 2
0.5
1.5
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 14, 2024
@alexs-sh
seq:add module for parsing hexadecimal floats
a7f688a 
Initial version of a hexadecimal float parser. This implementation is
intended for preview and further discussion.

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 14, 2024
@alexs-sh
seq:enable parsing of hexadecimal floats
f869213 
Turn on the float parser. Now it's possible to use hexadecimal floats as
parameters. For example,

    cargo run -- 0x1p-1 3
    0.5
    1.5
    2.5

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 14, 2024
@alexs-sh
seq:fix test
f77e2b0 
Issue uutils#6935
@alexs-sh alexs-sh mentioned this issue Dec 14, 2024
Draft
@alexs-sh
Copy link
Contributor

@aimerlief Thx

@alexs-sh
Copy link
Contributor

Hello, I'd like to work on this issue

@alexs-sh
Copy link
Contributor

#6959 - here is an early PR draft, which introduces support for hexadecimal floating points. Mainly to kick off the review process and gather feedback. Any comments or suggestions are welcome

alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 14, 2024
@alexs-sh
seq:fix fuzzer buld
e368cea 
This change fixes fuzz build and simplifies f64 / BigDecimal
conversions.

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 14, 2024
@alexs-sh
seq:update test for floating points
017ab3d 
Now test_parse_float_from_invalid_values checks the error code.

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 14, 2024
@alexs-sh
seq:floatparse:add license header
881534f 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 14, 2024
@alexs-sh
seq:floatparse:adjust spell-checker
e64c4c4 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 14, 2024
@alexs-sh
seq:floatparse:adjust spell-checker
bb32693 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 15, 2024
@alexs-sh
seq:add module for parsing hexadecimal floats
6b9e19d 
Initial version of a hexadecimal float parser. This implementation is
intended for preview and further discussion.

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 15, 2024
@alexs-sh
seq:enable parsing of hexadecimal floats
48aa069 
Turn on the float parser. Now it's possible to use hexadecimal floats as
parameters. For example,

    cargo run -- 0x1p-1 3
    0.5
    1.5
    2.5

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 15, 2024
@alexs-sh
seq:fix test
e704169 
Fix the test that fails after the implementation of the floating-point
format. The expected output now matches the GNU seq output.

    seq 0xlmnop
    seq: invalid floating point argument: ‘0xlmnop’

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 15, 2024
@alexs-sh
seq:floatparse:adjust spell-checker
6ef9921 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 15, 2024
@alexs-sh
seq:add more tests
b25be31 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 15, 2024
@alexs-sh
seq:add more tests
4f55794 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 15, 2024
@alexs-sh
seq:add more tests
9e88587 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 15, 2024
@alexs-sh
seq:add more tests
0fa1c61 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 16, 2024
@alexs-sh
seq:add module for parsing hexadecimal floats
59a81de 
Initial version of a hexadecimal float parser. This implementation is
intended for preview and further discussion.

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 16, 2024
@alexs-sh
seq:enable parsing of hexadecimal floats
449ba37 
Turn on the float parser. Now it's possible to use hexadecimal floats as
parameters. For example,

    cargo run -- 0x1p-1 3
    0.5
    1.5
    2.5

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 16, 2024
@alexs-sh
seq:fix test
05a8c9e 
Fix the test that fails after the implementation of the floating-point
format. The expected output now matches the GNU seq output.

    seq 0xlmnop
    seq: invalid floating point argument: ‘0xlmnop’

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 16, 2024
@alexs-sh
seq:floatparse:adjust spell-checker
5330269 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 16, 2024
@alexs-sh
seq:add more tests
5284545 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 16, 2024
@alexs-sh
seq:add module for parsing hexadecimal floats
d07ffd3 
Initial version of a hexadecimal float parser. This implementation is
intended for preview and further discussion.

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 16, 2024
@alexs-sh
seq:enable parsing of hexadecimal floats
1c1f028 
Turn on the float parser. Now it's possible to use hexadecimal floats as
parameters. For example,

    cargo run -- 0x1p-1 3
    0.5
    1.5
    2.5

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 16, 2024
@alexs-sh
seq:fix test
e63b27f 
Fix the test that fails after the implementation of the floating-point
format. The expected output now matches the GNU seq output.

    seq 0xlmnop
    seq: invalid floating point argument: ‘0xlmnop’

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 16, 2024
@alexs-sh
seq:floatparse:adjust spell-checker
c8e684d 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 16, 2024
@alexs-sh
seq:add more tests
dc44647 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 17, 2024
@alexs-sh
seq:add module for parsing hexadecimal floats
27db379 
Initial version of a hexadecimal float parser. This implementation is
intended for preview and further discussion.

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 17, 2024
@alexs-sh
seq:enable parsing of hexadecimal floats
ac0fb00 
Turn on the float parser. Now it's possible to use hexadecimal floats as
parameters. For example,

    cargo run -- 0x1p-1 3
    0.5
    1.5
    2.5

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 17, 2024
@alexs-sh
seq:fix test
bfd8f6e 
Fix the test that fails after the implementation of the floating-point
format. The expected output now matches the GNU seq output.

    seq 0xlmnop
    seq: invalid floating point argument: ‘0xlmnop’

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 17, 2024
@alexs-sh
seq:floatparse:adjust spell-checker
40a6524 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 17, 2024
@alexs-sh
seq:add more tests
8e4bcd8 
Issue uutils#6935
@gim913
Copy link
Contributor

gim913 commented Dec 22, 2024

Is this the same issue as #2660 ? (I guess the answer is yes)

@alexs-sh
Copy link
Contributor

Hello @gim913. Thank you for the information.

Yes, this is the same issue related to the missing support for hexadecimal floating-point numbers. I tested the text input from #2660 with the fixes from #6959, and the output is close to the expected result. However, additional work is required to reach 100% compatibility with the original seq output.

cargo run -- -0x.ep-3 -0x.1p-3 -0x.fp-3
-0.1093750
-0.1171875

vs

seq -0x.ep-3 -0x.1p-3 -0x.fp-3
-0.109375
-0.117188

alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 26, 2024
@alexs-sh
seq:add module for parsing hexadecimal floats
4129212 
Initial version of a hexadecimal float parser. This implementation is
intended for preview and further discussion.

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 26, 2024
@alexs-sh
seq:enable parsing of hexadecimal floats
ce2f85c 
Turn on the float parser. Now it's possible to use hexadecimal floats as
parameters. For example,

    cargo run -- 0x1p-1 3
    0.5
    1.5
    2.5

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 26, 2024
@alexs-sh
seq:fix test
37e3317 
Fix the test that fails after the implementation of the floating-point
format. The expected output now matches the GNU seq output.

    seq 0xlmnop
    seq: invalid floating point argument: ‘0xlmnop’

Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 26, 2024
@alexs-sh
seq:floatparse:adjust spell-checker
8d2efbe 
Issue uutils#6935
alexs-sh added a commit to alexs-sh/coreutils that referenced this issue Dec 26, 2024
@alexs-sh
seq:add more tests
db04ba0 
Issue uutils#6935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
U - seq
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cakebaker @gim913 @alexs-sh @aimerlief