Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do something with legacy skeleton datetime APIs #5611

Open
sffc opened this issue Sep 28, 2024 · 2 comments
Open

Do something with legacy skeleton datetime APIs #5611

sffc opened this issue Sep 28, 2024 · 2 comments
Labels
C-datetime Component: datetime, calendars, time zones needs-approval One or more stakeholders need to approve proposal

Comments

@sffc
Copy link
Member

sffc commented Sep 28, 2024

Currently they are behind the feature = "datagen" flag in icu_datetime. What should we do with them?

  1. Leave as-is, potentially with a bit of documentation. Question: does feature = "datagen" mean unstable?
  2. Move to icu::datetime::provider
  3. Move to icu_provider_source, the only client
  4. Make a new crate for it
  5. Other suggestions?

@zbraniecki @robertbastian @Manishearth

@sffc sffc added C-datetime Component: datetime, calendars, time zones needs-approval One or more stakeholders need to approve proposal labels Sep 28, 2024
@sffc sffc added this to the ICU4X 2.0 ⟨P1⟩ milestone Sep 28, 2024
@robertbastian
Copy link
Member

I'd prefer 3 or 2. I think we should get rid of all the markers, so there's probably not much of an advantage of 2.

@Manishearth
Copy link
Member

I agree, 3 or 2, preference for 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-datetime Component: datetime, calendars, time zones needs-approval One or more stakeholders need to approve proposal
Projects
None yet
Development

No branches or pull requests

3 participants