From f3529ffb853a7f5611eac5aaeabbd417cb0787da Mon Sep 17 00:00:00 2001 From: marekbiczysko Date: Mon, 7 Oct 2024 16:18:07 +0200 Subject: [PATCH] ut fix --- .../services/biometric_deduplication.py | 2 +- .../test_biometric_deduplication_service.py | 18 ++++-------------- 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/src/hct_mis_api/apps/registration_datahub/services/biometric_deduplication.py b/src/hct_mis_api/apps/registration_datahub/services/biometric_deduplication.py index 37e55f0266..1c0dfb4be6 100644 --- a/src/hct_mis_api/apps/registration_datahub/services/biometric_deduplication.py +++ b/src/hct_mis_api/apps/registration_datahub/services/biometric_deduplication.py @@ -234,7 +234,7 @@ def get_duplicate_individuals_for_rdi_against_batch_count(self, rdi: Registratio def get_duplicates_for_merged_rdi_against_population( self, rdi: RegistrationDataImport ) -> QuerySet[DeduplicationEngineSimilarityPair]: - """Used in Grievance tickets creation for merged RDI""" + """Used in Grievance tickets creation for merging RDI""" rdi_pending_individuals = PendingIndividual.objects.filter(is_removed=False, registration_data_import=rdi).only( "id" ) diff --git a/tests/unit/apps/registration_datahub/test_biometric_deduplication_service.py b/tests/unit/apps/registration_datahub/test_biometric_deduplication_service.py index 95f263a93b..df58fa0c3a 100644 --- a/tests/unit/apps/registration_datahub/test_biometric_deduplication_service.py +++ b/tests/unit/apps/registration_datahub/test_biometric_deduplication_service.py @@ -471,26 +471,16 @@ def test_get_duplicates_for_merged_rdi_against_population(self) -> None: ] service.store_similarity_pairs(str(self.program.deduplication_set_id), similarity_pairs) - duplicates = service.get_duplicates_for_merged_rdi_against_population(rdi1) + duplicates = service.get_duplicates_for_merged_rdi_against_population(rdi2) - assert len(duplicates) == 3 + assert len(duplicates) == 1 assert list( duplicates.order_by("similarity_score").values("individual1", "individual2", "similarity_score") ) == [ { - "individual1": ind1.id, - "individual2": ind2.id, - "similarity_score": Decimal("70.00"), - }, - { - "individual1": ind1.id, + "individual1": ind4.id, "individual2": ind5.id, - "similarity_score": Decimal("80.00"), - }, - { - "individual1": ind2.id, - "individual2": ind6.id, - "similarity_score": Decimal("90.00"), + "similarity_score": Decimal("70.00"), }, ]