Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggesting the owner to add a contribution file #832

Closed
SharifDer opened this issue Sep 13, 2024 · 3 comments
Closed

Suggesting the owner to add a contribution file #832

SharifDer opened this issue Sep 13, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@SharifDer
Copy link

Hey there, I'm working on a project that requires technical analysis and there some indicators that I would like to use that are not available on the pandas_ta, so I thought it would be a good idea to contribute what I can for the this amazing lib. The issue is that I can't a contribution file that can give me the instruction of contribution should work in this lib.

@SharifDer SharifDer added the enhancement New feature or request label Sep 13, 2024
@twopirllc
Copy link
Owner

Hello @SharifDer,

Sorry if I am uncertain what you are asking. Are you asking how to contribute?

If so, it is pretty simple. First, check out the development branch and find an indicator(s) that are similar to the ones you want to include. Then follow the pinned Issue Creating a Custom Indicator: The Big 4. Although some details are out dated, the concepts still apply:

  1. Create the indicator
  2. Make sure you can run it and the tests are up to your standards.
  3. Then hook it up the the Pandas DataFrame Extension and test it.

If this is not what you meant, please clarify so I can address it properly.

Kind Regards,
KJ

@bhawani0x
Copy link

I think you need to update this #355 , its not working anymore

@twopirllc
Copy link
Owner

@bhawani0x

Contributions are always welcome! So much to do. 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants