Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComposableNaming is not configurable in Detekt #107

Open
ZacSweers opened this issue Oct 28, 2022 · 1 comment
Open

ComposableNaming is not configurable in Detekt #107

ZacSweers opened this issue Oct 28, 2022 · 1 comment

Comments

@ZacSweers
Copy link
Contributor

This is a followup from #104

I've tried all of these different configurations for the new functionality and none of them appear to work. It seems to me that this rule is somehow not configurable in its release. Did I miss something in my PR?

TwitterCompose:
  # Not top level
  allowedComposableFunctionNames: ['.*Presenter']
  # ComposeNaming and ComposableNaming are both used, so tried configuring both without success
  ComposeNaming:
    active: true
    allowedComposableFunctionNames: ['.*Presenter']
  ComposableNaming:
    active: true
    allowedComposableFunctionNames: ['.*Presenter']

Repro: slackhq/circuit#225

@mrmans0n
Copy link
Contributor

mrmans0n commented Oct 28, 2022

Try this:

TwitterCompose:
  ComposableNaming:
    active: true
    allowedComposableFunctionNames: .*Presenter

If it doesn't work I'll get back to you next week (currently @ droidcon London) and we'll get it sorted out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants