Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crest-maven-plugin: add java 11 support, upgrade ASM to >6 #89

Open
stefan-lange opened this issue Sep 10, 2021 · 7 comments
Open

crest-maven-plugin: add java 11 support, upgrade ASM to >6 #89

stefan-lange opened this issue Sep 10, 2021 · 7 comments

Comments

@stefan-lange
Copy link

We have a project with java 11, which uses th crest-maven-plugin.

This combination is not possible due to the old version of ASM. We get errors like this This feature requires ASM7.

It would be great, if the maven plugin could use a version of ASM > 6 with java 11 support, see https://asm.ow2.io/versions.html.

@jgallimore
Copy link
Member

Would this PR work for you? #90? I should be able to push a snapshot for you to test with, if that helps.

@stefan-lange
Copy link
Author

Thx, tested it locally. The PR has no effect on my problem.

The dependency in crest-maven-plugin/pom.xml is the problem. This should be upgraded.

    <dependency>
      <groupId>org.ow2.asm</groupId>
      <artifactId>asm</artifactId>
      <version>6.0_ALPHA</version>
    </dependency>

In combination with the ASM version in CrestCommandLoaderDescriptorGeneratorMojo. It is ASM6 at this moment. I don't know what side effects this will cause.

@jgallimore
Copy link
Member

Thanks for the feedback. Could I get you to re-review now? I've bumped that up to ASM9 too.

@stefan-lange
Copy link
Author

I've tested the crest-maven-plugin-0.16-SNAPSHOT on my machine. No more compile errors. Thank you, it looks great!

@stefan-lange
Copy link
Author

When will this be released approx.? :)

@jgallimore
Copy link
Member

I'll cut a release this afternoon, thanks for you feedback!

@AndyGee
Copy link
Contributor

AndyGee commented Oct 18, 2021

This is really nice of you Jon. Thank you so much for your time. You're a star!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants