Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid using magic numbers like 10 ** 7 in grid client #3420

Open
0oM4R opened this issue Sep 18, 2024 · 1 comment
Open

avoid using magic numbers like 10 ** 7 in grid client #3420

0oM4R opened this issue Sep 18, 2024 · 1 comment
Milestone
2.7.0

Comments

@0oM4R
Copy link
Contributor

0oM4R commented Sep 18, 2024

I would avoid using magic numbers like 10 ** 7 and define it as constant TFT_CONVERSION_FACTOR (maybe in the client) then use it everywhere else for clarity and maintainability.

Originally posted by @sameh-farouk in #3387 (comment)
@ramezsaeed ramezsaeed added this to the 2.6.0 milestone Sep 22, 2024
@maayarosama
Copy link
Contributor

Should be done in all conversion across the grid

@AhmedHanafy725 AhmedHanafy725 modified the milestones: 2.6.0, 2.7.0 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
4 participants
@ramezsaeed @AhmedHanafy725 @0oM4R @maayarosama