Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an ability to pass custom Archiver to ArchiverCompressorDecorator #56

Open
hvarakhobava opened this issue May 15, 2017 · 1 comment

Comments

@hvarakhobava
Copy link

Hi,

It is very desirable to have an ability to pass own implementation of Archiver interface to ArchiverCompressorDecorator.
Since the last one is package-private, please either make it public or make a new static factory method in ArchiverFactory as follow:

public static Archiver createArchiver(Archiver archiver, CompressionType compression) {
// do stuff
}

@thrau
Copy link
Owner

thrau commented May 15, 2017

ArchiverCompressorDecorator only take CommonsArchiver instances, which are also package private. I don't see much harm in making the classes public, but jarchivelib wasn't designed to be open to extensions and alternative archive providers, which is why the API exposure is minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants