Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate archiver/compressor auto-detection behavior #18

Open
thrau opened this issue Apr 1, 2014 · 0 comments
Open

Separate archiver/compressor auto-detection behavior #18

thrau opened this issue Apr 1, 2014 · 0 comments
Milestone

Comments

@thrau
Copy link
Owner

thrau commented Apr 1, 2014

The commons stream factories provide methods for creating input-streams based on auto-detection. This functionality is currently used without any kind of consideration. Archivers can extract anything that is auto-detectable by the ArchiveStreamFactory, because CommonsArchiver creates the streams by passing the InputStream of the file to extract, rather than the archive format.
While this may be a convenient behavior in some cases, its confusing, unclean and can cause issues where archive/compression types may actually not be auto-detectable (all the new compression formats, or JAR for example).

ArchiveStreamFactory cannot tell JAR archives from ZIP archives and will not auto-detect JARs.

Auto-detection should but be segregated and properly documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant