Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVLTreeDigest can have centroids out of order #169

Open
tdunning opened this issue Jun 1, 2021 · 0 comments · May be fixed by #209
Open

AVLTreeDigest can have centroids out of order #169

tdunning opened this issue Jun 1, 2021 · 0 comments · May be fixed by #209

Comments

@tdunning
Copy link
Owner

tdunning commented Jun 1, 2021

The test com.tdunning.math.stats.TDigestTest#testSorted can fail with out of order centroids:

previous = {Centroid@1053} "Centroid{centroid=0.9999500019381296, count=5}"
 centroid = 0.9999500019381296
 count = 5
 id = 370
 actualData = null
centroid = {Centroid@1054} "Centroid{centroid=0.9999500019381294, count=3}"

Replicate (sometimes) with

mvn test -Dtests.seed=B382E9EF2739FED -DrunSlowTests=false -Dtests.class=com.tdunning.math.stats.AVLTreeDigestTest
@tdunning tdunning mentioned this issue Dec 23, 2021
Merged
kinow added a commit to kinow/t-digest that referenced this issue May 8, 2023
@kinow
Close tdunning#169 Re-order terms in division to avoid periodic decim…
74996c7 
…al and rounding issues in Centroid#add, fixing out-of-order centroids
@kinow kinow linked a pull request May 8, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tdunning