Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Extract Description into separate component. #36

Closed
dantleech opened this issue Aug 27, 2016 · 4 comments
Closed

Extract Description into separate component. #36

dantleech opened this issue Aug 27, 2016 · 4 comments

Comments

@dantleech
Copy link
Member

All of the current desciption enhancers act upon the Payload - i.e. they don't really care about the resource.

This is not to say that enhancers can't act on the resource itself (e.g. actual files) but just that currently none of the do.

We can extract the Description stuff into a separate component that acts upon objects of any type, not just PuliResource instances.

CmfResource instances can still be supported - we just make a PuliResource enhancer which is a "proxy" to the descrition for the payload and other Puli resources (e.g. FileResource) can still be handled.

@dantleech
Copy link
Member Author

If moving we should also adopt class based descriptors: #25

@wouterj wouterj closed this as completed Jan 26, 2017
@dantleech
Copy link
Member Author

Why was this closed?

@wouterj
Copy link
Member

wouterj commented Jan 28, 2017

It's now distracted in a component in Psiphp, isn't it? And using that component once it's stable is mentioned in #38

@dantleech
Copy link
Member Author

ok, makes sense :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants