Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate image/ file upload response #34

Open
dbu opened this issue Aug 15, 2013 · 3 comments
Open

investigate image/ file upload response #34

dbu opened this issue Aug 15, 2013 · 3 comments
Labels

Comments

@dbu
Copy link
Member

dbu commented Aug 15, 2013

We abstracted the image / file upload for Create and other web editors in UploadFileHelper::getUploadResponse.

The logic is currently ported from the CreateBundle and improved at some points. We should investigate the response more, questions raised are:

  • I don't know much about how CkEditor works, so this may not be applicable, but shouldn't we be returning a "application/json" response and using a callback in the frontend to call functions rather than returning HTML? (dantleech)
    • We now return javascript directly for the ckeditor but could investigate when we implement the ckeditor for the CreateBundle - possibly also in combination with elfinder.
    • follow up of CreateBundle #27 (comment)
  • I wonder if it is a good idea to refer to an "editor" here. (in UploadFileHelper::getUploadResponse) Could we not use this upload thingy from a web form, or something else? (dantleech)
@lsmith77
Copy link
Member

@rmsint do you know more details about this one?

@rmsint
Copy link
Contributor

rmsint commented Aug 19, 2013

@lsmith77 added details to the issue description above

@lsmith77
Copy link
Member

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants