Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doom-modeline checker segment fails to report flymake errors #14133

Open
zane opened this issue Nov 14, 2020 · 7 comments
Open

doom-modeline checker segment fails to report flymake errors #14133

zane opened this issue Nov 14, 2020 · 7 comments
Assignees
Labels

Comments

@zane
Copy link

zane commented Nov 14, 2020

Description :octocat:

doom-modeline checker segment does not include errors.

Reproduction guide 🪲

The instructions below are for triggering an elisp error, but I believe this bug can be reproduced with any flycheck error.

I could not reproduce this bug on a vanilla Emacs configuration, so I believe this is not an issue upstream.

  • In .spacemacs set dotspacemacs-mode-line-theme to 'doom
  • In .spacemacs add syntax-checking to dotspacemacs-configuration-layers
  • Start Emacs
  • Open a new .el file, insert x), and save.
  • Enable flycheck-mode for the .el file buffer.
  • (Optional) Press SPC e l and note that flycheck is indeed reporting 5 info messages, 1 warning, and 1 error.

Observed behaviour: 👀 💔
The checker segment in the modeline shows ":no_entry_sign: 0".

Expected behaviour: ❤️ 😄
The checker segment in the modeline shows ":no_entry_sign: 7".

System Info 💻

  • OS: darwin
  • Emacs: 27.1
  • Spacemacs: 0.300.0
  • Spacemacs branch: develop (rev. 184bb2b)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(emacs-lisp helm multiple-cursors syntax-checking treemacs)
  • System configuration features: RSVG IMAGEMAGICK GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS JSON PDUMPER LCMS2 GMP

Backtrace 🐾

Not applicable.

@zane zane changed the title doom-modeline checker segment does not include clj-kondo errors doom-modeline checker segment fails to show errors and warnings Nov 14, 2020
@zane zane changed the title doom-modeline checker segment fails to show errors and warnings doom-modeline checker segment fails to reflect flymake errors Nov 14, 2020
@zane zane changed the title doom-modeline checker segment fails to reflect flymake errors doom-modeline checker segment fails to report flymake errors Nov 14, 2020
@sauvala
Copy link

sauvala commented Jan 2, 2021

I have this issue also. The checker doesn't reflect flychecker errors/warnings like you described. I tested this in the init.el config file and also in some Clojure code.

@lebensterben
Copy link
Collaborator

@zane
I can confirm this bug for emacs-lisp-mode.

@theophilusx
Copy link

I can also confirm this with Javascript, lsp-mode and flycheck (lsp-mode linting disabled). The segment in the mode line showing errors always show 0 if there are any errors and a green tick if there are none. Switching the mode-line to spacemacs default and errors are shown correctly.

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Sep 10, 2022
@lebensterben lebensterben removed the stale marked as a stale issue/pr (usually by a bot) label Sep 10, 2022
Repository owner deleted a comment from github-actions bot Sep 11, 2022
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Jan 20, 2024
@zane
Copy link
Author

zane commented Jan 20, 2024

Still an issue!

@github-actions github-actions bot removed the stale marked as a stale issue/pr (usually by a bot) label Jan 20, 2024
@smile13241324 smile13241324 self-assigned this Sep 5, 2024
@fnussbaum
Copy link
Contributor

I cannot reproduce this with the newest doom-modeline, perhaps it works since seagle0128/doom-modeline@2001454? It works correctly for both values of doom-modeline-check-simple-format for me.

@smile13241324
Copy link
Collaborator

@zane please double check with the latest package versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants