Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interpolation observers without overhead of interpolation framework #6238

Open
nilsvu opened this issue Aug 21, 2024 · 0 comments
Open

Comments

@nilsvu
Copy link
Member

nilsvu commented Aug 21, 2024

It would be helpful to have interpolation events like #3688 that do simple interpolations (e.g. to a point or line) without the overhead that comes with the interpolation framework. It's quite complicated to add interpolation targets with the framework, involving adding structs to the metavariables, and it comes with options in the input file that are split between the "InterpolationTargets" section and the "EventsAndTriggers". It also involves either adding the interpolator parallel component, or using InterpolateWithoutInterpComponent, which is also quite complicated.
However, it's possible and actually quite straightforward to interpolate to points just within an event and write the result to a file, all contained within the event hpp/cpp, see #3688. The complicated features of the interpolation framework, which was built for dynamic horizon finding, are not needed for this. I propose we add simple observers, each contained within their event hpp/cpp, that interpolate to a point, a line, a sphere, etc. We can do this in post processing using spectre.IO.Exporter.interpolate_to_points, but it would be helpful to do this during simulations to reduce the data written out to disk (or to be able to measure these quantities at higher frequency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant