Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action that does consistency/sanity checks on time stepper history #6237

Open
nilsvu opened this issue Aug 21, 2024 · 0 comments
Open

Add action that does consistency/sanity checks on time stepper history #6237

nilsvu opened this issue Aug 21, 2024 · 0 comments

Comments

@nilsvu
Copy link
Member

nilsvu commented Aug 21, 2024

@knelli2 wrote in #4690:

While working with CCM, I've been burned a couple times now by self-start not completing properly. There is nothing wrong with the self start code itself. However, if there is a deadlock in the StepActions, then because of quiescence detection, the self-start phase will finish (without error) and the algorithm continues to the evolution with incorrect time stepper history. This can cause all sorts of problems in the evolution and make things hard to debug.

This PR adds a new action that does some consistency/sanity checks on the history data so as to avoid this. Because quiescence can sometimes happen during self start (which we don't want), we can't put this action in the self-start phase itself because the action won't get run. We also don't want to put this in the Evolve phase because this check only needs to be done once. So I added a new phase CheckTimeStepperHistory that goes between self-start and evolve to do these checks.

For lack of time this PR stalled, but it would be nice to revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant