Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHEREUM-CONTRACTS] improve testability of custom (mostly pure) SuperTokens #1852

Open
d10r opened this issue Jan 19, 2023 · 1 comment
Open
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Tag: Idea Raw idea, questions, thoughts and brainstorming notes Team: DevX Type: Testing Testing cases or harness improvements

Comments

@d10r
Copy link
Collaborator

d10r commented Jan 19, 2023

During the development of GoodDollar SuperToken, the issue of testability came up. It's a custom Pure SuperToken which overrides some of the stock SuperToken logic - it also deploys its own - slightly modified - version of SuperToken logic.
Because of this changes, the project owner wanted to run the SF test suite against the token in order to feel more confident about not accidentally breaking something.
It ended up being easier to add the GD contracts to a copy of the SF repo than to port tests.

Task: investigate how we could make it easier for cases like this to get enough test coverage. Example usage could then be shown in https://github.com/superfluid-finance/custom-supertokens/.

@hellwolf hellwolf added the Tag: Idea Raw idea, questions, thoughts and brainstorming notes label Jan 23, 2023
@hellwolf hellwolf added Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Tag: Help Me Whelp! extra attention is needed here labels Aug 23, 2023
@hellwolf
Copy link
Contributor

how's the testability now?

@hellwolf hellwolf removed Tag: Idea Raw idea, questions, thoughts and brainstorming notes Tag: Help Me Whelp! extra attention is needed here labels Sep 27, 2023
@hellwolf hellwolf added Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Type: Testing Testing cases or harness improvements labels Jan 18, 2024
@hellwolf hellwolf transferred this issue from superfluid-finance/protocol-monorepo Jan 23, 2024
@hellwolf hellwolf added Team: DevX and removed Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps labels Jan 23, 2024
@hellwolf hellwolf assigned hellwolf and youssefea and unassigned hellwolf Jan 23, 2024
@hellwolf hellwolf transferred this issue from another repository Mar 5, 2024
@hellwolf hellwolf added the Tag: Idea Raw idea, questions, thoughts and brainstorming notes label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Tag: Idea Raw idea, questions, thoughts and brainstorming notes Team: DevX Type: Testing Testing cases or harness improvements
Projects
None yet
Development

No branches or pull requests

3 participants