Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: find a solution for linting/formatting on Windows #129

Open
t-bre opened this issue Oct 22, 2022 · 4 comments · Fixed by #152
Open

chore: find a solution for linting/formatting on Windows #129

t-bre opened this issue Oct 22, 2022 · 4 comments · Fixed by #152
Labels
chore Miscellaneous chores

Comments

@t-bre
Copy link
Member

t-bre commented Oct 22, 2022

Description

Trunk isn't supported on Windows, which is quite unfortunate. Some options to look into:

  • Using Trunk on WSL, and doing all git operations from there (disruptive to general workflow?).
  • Running clang-tidy and clang-format manually from Windows (loses the benefits of Trunk).
  • Setting up CI on GitHub to run the Trunk check action.
@t-bre t-bre added the chore Miscellaneous chores label Oct 22, 2022
@t-bre t-bre changed the title chore(trunk): find a solution for linting/formatting on Windows chore: find a solution for linting/formatting on Windows Oct 22, 2022
@inventor02
Copy link
Member

Setting up CI on GitHub to run the Trunk check action.

I have (quite extensive) experience with CI and I was actually thinking something like this would be useful anyway so if this is the option we go with I am happy to discuss this/look at this on Tues?

@t-bre
Copy link
Member Author

t-bre commented Oct 23, 2022

That sounds great! We don't have any real experience with CI tools as a team, so I think we could really benefit from that. I know a few people would be interested to learn more in general, so if you can get something set up for this repo it would be a good example for how it might work for other projects / in future.

We can discuss more in the next meeting 👍

@niketa282
Copy link
Contributor

Setting up CI on GitHub to run the Trunk check action.

I have (quite extensive) experience with CI and I was actually thinking something like this would be useful anyway so if this is the option we go with I am happy to discuss this/look at this on Tues?

Would be interested to know how you do this and learn about it

@t-bre t-bre linked a pull request Nov 30, 2022 that will close this issue
@t-bre
Copy link
Member Author

t-bre commented Nov 30, 2022

This is sort of closed by #152, but it might be worth finding out how to run clang-format and clang-tidy on Windows without Trunk otherwise fixing issues might be quite a pain for Windows users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Miscellaneous chores
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants