Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Exporting types to have more modularity in our implementation #38

Open
oktapodia opened this issue May 31, 2024 · 1 comment
Open
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature

Comments

@oktapodia
Copy link

A clear and concise description of what the feature is

the package got a lot of interfaces not exported which is making the usage harder for an example, BlocksRendererProps if we want to auto-generate the blocks

Why should this feature be included?

That's quite common to export the type for reusability

Please provide an example for how this would work

interface BlocksRendererProps {
    content: RootNode[];
    blocks?: Partial<BlocksComponents>;
    modifiers?: Partial<ModifiersComponents>;
}

to

export interface BlocksRendererProps {
    content: RootNode[];
    blocks?: Partial<BlocksComponents>;
    modifiers?: Partial<ModifiersComponents>;
}
@oktapodia oktapodia added the issue: enhancement Issue suggesting an enhancement to an existing feature label May 31, 2024
@Kirsten1996
Copy link

Any update on this here issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants