[Bug]: Cannot find module 'storybook/internal/common' #505

eavam · 2024-08-16T15:58:39Z

Describe the bug

Running yarn test-storybook responds with an error Cannot find module 'storybook/internal/common'.
On version 0.16 everything is fine. With 0.17 the problems start.

To Reproduce

node:internal/modules/cjs/loader:1147
  throw err;
  ^

Error: Cannot find module 'storybook/internal/common'
Require stack:
- <-- PATH -->/node_modules/@storybook/test-runner/node_modules/@storybook/core-common/shim.js
- <-- PATH -->/node_modules/@storybook/test-runner/dist/test-storybook.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
    at Module._load (node:internal/modules/cjs/loader:985:27)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (<-- PATH -->/node_modules/@storybook/test-runner/node_modules/@storybook/core-common/shim.js:1:18)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Module.require (node:internal/modules/cjs/loader:1235:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '<-- PATH -->/node_modules/@storybook/test-runner/node_modules/@storybook/core-common/shim.js',
    '<-- PATH -->/node_modules/@storybook/test-runner/dist/test-storybook.js'
  ]
}

System

System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M1 Max
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    Yarn: 4.1.1 - ~/.nvm/versions/node/v20.10.0/bin/yarn <----- active
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
  Browsers:
    Chrome: 127.0.6533.120
    Safari: 17.5
  npmPackages:
    @storybook/addon-essentials: 8.1.1 => 8.1.1 
    @storybook/addon-interactions: 8.1.1 => 8.1.1 
    @storybook/addon-links: 8.1.1 => 8.1.1 
    @storybook/blocks: 8.1.1 => 8.1.1 
    @storybook/preview-api: 8.1.1 => 8.1.1 
    @storybook/react: 8.1.1 => 8.1.1 
    @storybook/react-vite: 8.1.1 => 8.1.1 
    @storybook/test: 8.1.1 => 8.1.1 
    @storybook/test-runner: 0.17.0 => 0.17.0 
    eslint-plugin-storybook: 0.8.0 => 0.8.0 
    msw-storybook-addon: 2.0.3 => 2.0.3 
    storybook: 8.1.1 => 8.1.1 
    storybook-addon-mock: 5.0.0 => 5.0.0

Additional context

No response

The text was updated successfully, but these errors were encountered:

kumarbha · 2024-08-19T09:52:41Z

I am also facing the same issue. Pls help

bklatka · 2024-08-21T11:07:47Z

Facing same issue as above

dudiharush · 2024-08-22T10:40:19Z

Me too...

dudiharush · 2024-08-25T17:59:14Z

This bug seems to be resolved after running: npx [email protected] upgrade @eavam @kumarbha

SoaresMG · 2024-08-27T08:26:44Z

Same here, but I'm using [email protected] with @storybook/[email protected] (I have also tried 0.19.1).

I did upgrade other deps that's when the issue started happening, I'm trying to find which one caused it

ericsoderberghp · 2024-08-28T03:12:13Z

FYI, I've found that if I remove @storybook/addon-designs then the error goes away and I am able to run.

SoaresMG · 2024-08-28T07:24:06Z

Same here, but I'm using [email protected] with @storybook/[email protected] (I have also tried 0.19.1).

I did upgrade other deps that's when the issue started happening, I'm trying to find which one caused it

It seems that my issue was related with being in storybook@7 using [email protected] which had storybook@8 deps.

I switched to 0.16.0 and it started working again.

It was working before with storybook@7 due to the magic hand of the lock file god, that allowed some [email protected] deps to be mixed with storybook@7 itself (if I'm not mistaken it was some deps like @storybook/channels and @storybook/types and 1-2 more).

sunilrathore24 · 2024-09-06T12:00:55Z

Same here -
it used to work earlier but probably because of some minor version upgrades, it fails with the below error.
@yannbf can you look into it?

  "devDependencies": {
    "@angular-devkit/build-angular": "18.0.2",
    "@angular-devkit/core": "18.0.2",
    "@angular-devkit/schematics": "18.0.2",
    "@angular-eslint/eslint-plugin": "18.0.1",
    "@angular-eslint/eslint-plugin-template": "18.0.1",
    "@angular-eslint/template-parser": "18.0.1",
    "@angular/cli": "~18.0.0",
    "@angular/compiler-cli": "18.0.1",
    "@angular/language-service": "18.0.1",
    "@babel/core": "^7.24.7",
    "@babel/plugin-proposal-decorators": "^7.24.7",
    "@babel/preset-env": "^7.24.7",
    "@babel/preset-typescript": "^7.24.7",
    "@commitlint/cli": "^17.0.2",
    "@commitlint/config-conventional": "^17.0.2",
    "@commitlint/prompt-cli": "^17.0.0",
    "@custom-elements-manifest/analyzer": "~0.5.7",
    "@mjhenkes/postcss-rtl": "^2.0.0",
    "@nx/cypress": "19.3.2",
    "@nx/eslint": "19.3.2",
    "@nx/eslint-plugin": "19.3.2",
    "@nx/js": "19.3.2",
    "@nx/storybook": "19.3.2",
    "@nx/workspace": "19.3.2",
    "@open-wc/testing": "^3.1.6",
    "@rollup/plugin-alias": "^5.1.0",
    "@rollup/plugin-node-resolve": "^15.2.3",
    "@rollup/plugin-terser": "^0.4.4",
    "@rollup/plugin-typescript": "^11.1.6",
    "@rollup/plugin-virtual": "^3.0.2",
    "@schematics/angular": "18.0.2",
    "@storybook/addon-a11y": "^8.1.7",
    "@storybook/addon-essentials": "^8.1.7",
    "@storybook/addon-webpack5-compiler-babel": "^3.0.3",
    "@storybook/angular": "^8.1.7",
    "@storybook/blocks": "^8.1.7",
    "@storybook/components": "^8.1.7",
    "@storybook/core-events": "^8.1.7",
    "@storybook/core-server": "^8.1.7",
    "@storybook/manager-api": "^8.1.7",
    "@storybook/preview-api": "^8.1.7",
    "@storybook/test-runner": "^0.19.1",
    "@storybook/theming": "^8.1.7",
    "@storybook/types": "^8.1.7",
    "@storybook/web-components": "^8.1.7",
    "@storybook/web-components-webpack5": "^8.1.7" }

ekeijl · 2024-10-10T12:41:24Z

Running into the same issue when using Yarn PnP:

> yarn run storybook-test

/<REDACTED>/.pnp.cjs:67456
      Error.captureStackTrace(firstError);
            ^

Error: @storybook/core-common tried to access storybook (a peer dependency) but it isn't provided by its ancestors; this makes the require call ambiguous and unsound.

Required package: storybook (via "storybook/internal/common")
Required by: @storybook/core-common@virtual:fa7a63bce88eef2cb8a3f1c5ece91110f0f08289f1e8517bf01d3d69cbeef0a9a7bfcaa746c2f0e178177003417e002337645312a23a1888f0c1e9c5fa39c856#npm:8.2.9 (via /<REDACTED>/.yarn/__virtual__/@storybook-core-common-virtual-14814bf21c/0/cache/@storybook-core-common-npm-8.2.9-cf49c5e44e-0d70bd588a.zip/node_modules/@storybook/core-common/)

Ancestor breaking the chain: @storybook/test-runner@npm:0.19.1

It seems the @storybook/test-runner package is missing a peerDependency on the storybook package?

As a workaround, this can be patched with Yarn in your .yarnrc.yml (docs):

packageExtensions:
   '@storybook/test-runner@*':
      peerDependencies:
         storybook: ">=8"

Make sure to install the storybook package as a devDependency in your project.

yannbf · 2024-11-04T14:39:35Z

Hey everyone! Thanks for reporting this.

Here is a quick summary:

This issue is the result of a structural change that was done in Storybook 8.2, which affects the way packages are requested from other dependencies.
This issue only happens if you are using Storybook 8 dependencies, could be coming from an addon like @storybook/addon-designs for instance.
If you are using Storybook 7, you must stay at version 0.16.0 of the test-runner, as stated in this table.
I have a PR that updates the test-runner itself to follow the new structure of packages from Storybook, which should resolve this issue. This should be fixed in the next minor release of the test-runner.

## Current Behavior  I got this error locally, I think it is because @storybook/test-runner is incompatible with storybook version storybookjs/test-runner#505 <img width="1147" alt="Screenshot 2024-11-15 at 12 22 13 PM" src="https://github.com/user-attachments/assets/e2a9f4c9-e784-4946-8677-b60b62ff36ef"> from https://github.com/storybookjs/test-runner#storybook-compatibility storybook ^8.2.0 should use @storybook/test-runner ^0.19.0 ## Expected Behavior  ## Related Issue(s)  Fixes #

eavam added bug Something isn't working needs triage labels Aug 16, 2024

yannbf mentioned this issue Nov 4, 2024

Align with Storybook 8.2 core package layout #512

Merged

3 tasks

yannbf closed this as completed in #512 Nov 4, 2024

xiongemi mentioned this issue Nov 15, 2024

feat(storybook): upgrade @storybook/test-runner to 0.19 nrwl/nx#28959

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: Cannot find module 'storybook/internal/common' #505

[Bug]: Cannot find module 'storybook/internal/common' #505

eavam commented Aug 16, 2024 •

edited

Loading

kumarbha commented Aug 19, 2024

bklatka commented Aug 21, 2024

dudiharush commented Aug 22, 2024

dudiharush commented Aug 25, 2024

SoaresMG commented Aug 27, 2024

ericsoderberghp commented Aug 28, 2024

SoaresMG commented Aug 28, 2024

sunilrathore24 commented Sep 6, 2024 •

edited

Loading

ekeijl commented Oct 10, 2024 •

edited

Loading

yannbf commented Nov 4, 2024

[Bug]: Cannot find module 'storybook/internal/common' #505

[Bug]: Cannot find module 'storybook/internal/common' #505

Comments

eavam commented Aug 16, 2024 • edited Loading

Describe the bug

To Reproduce

System

Additional context

kumarbha commented Aug 19, 2024

bklatka commented Aug 21, 2024

dudiharush commented Aug 22, 2024

dudiharush commented Aug 25, 2024

SoaresMG commented Aug 27, 2024

ericsoderberghp commented Aug 28, 2024

SoaresMG commented Aug 28, 2024

sunilrathore24 commented Sep 6, 2024 • edited Loading

ekeijl commented Oct 10, 2024 • edited Loading

yannbf commented Nov 4, 2024

eavam commented Aug 16, 2024 •

edited

Loading

sunilrathore24 commented Sep 6, 2024 •

edited

Loading

ekeijl commented Oct 10, 2024 •

edited

Loading