Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FinishCopyObject endpoint should accept new metadata #4483

Closed
mniewrzal opened this issue Feb 14, 2022 · 3 comments
Closed

FinishCopyObject endpoint should accept new metadata #4483

mniewrzal opened this issue Feb 14, 2022 · 3 comments
Assignees
@mniewrzal
Milestone
Server Side Copy

Comments

@mniewrzal
Copy link
Contributor

mniewrzal commented Feb 14, 2022 •
edited
Loading

While doing server-side copy object we need to support two ways of handling metadata:

  • by default copy metadata from original object
  • on-demand set new metadata to copy

This ticket is to support this second option and this is part of satellite implementation. Uplink implementation has a separate ticket storj/uplink#81.
@mniewrzal mniewrzal added this to the Server Side Copy milestone Feb 14, 2022
@mniewrzal mniewrzal mentioned this issue Feb 14, 2022
Closed
@storjBuildBot
Copy link
Collaborator

Change https://review.dev.storj.io/c/storj/common/+/6980 mentions this issue.

@Erikvv Erikvv self-assigned this Mar 1, 2022
storjBuildBot pushed a commit to storj/common that referenced this issue Mar 3, 2022
@mniewrzal
pb: add option to set new metadata while finish object copy
ed2455d 
storj/storj#4483

Change-Id: I671eff0d5483dcde7aa564d4e9c0a5b13de9ba35
@mniewrzal mniewrzal assigned mniewrzal and unassigned Erikvv Mar 3, 2022
@storjBuildBot
Copy link
Collaborator

Change https://review.dev.storj.io/c/storj/common/+/6990 mentions this issue.

storjBuildBot pushed a commit to storj/common that referenced this issue Mar 3, 2022
@mniewrzal
pb: add field override_metadata to ObjectFinishCopyRequest
2150c02 
This will new field will give us ability to verify if destination
object metadata should be preserved or overridden with newly
provided.

storj/storj#4483

Change-Id: Ib80f357584828fcafda410dbcca3da8a3448bf5a
@storjBuildBot
Copy link
Collaborator

Change https://review.dev.storj.io/c/storj/storj/+/6999 mentions this issue.

dlamarmorgan pushed a commit that referenced this issue Oct 18, 2022
@mniewrzal @dlamarmorgan
satellite/metabase: handle NewEncryptedMetadata while coping object
6547ba9 
Copy object functionality should support setting new metadata for
copy. This change is adjusting FinishCopyObject method to set new
metadata when OverrideMetadata field is set to true.

Fixes #4483

Change-Id: Ica37cb57e8edae301cdc483fbda4f3ddba5d2702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mniewrzal mniewrzal

Labels
None yet
Projects
Metainfo Team
Archived in project
Milestone
Server Side Copy
Development

No branches or pull requests
3 participants
@Erikvv @mniewrzal @storjBuildBot