Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a quick design for preventing Storj Select accesses registration mismatches #506

Open
amwolff opened this issue Sep 16, 2024 · 0 comments
Open
Labels
authservice edge Feature Request SOC2 Compliance - Edge Services storage/migration of data needs to be soc2 compliant

Comments

@amwolff
Copy link
Member

amwolff commented Sep 16, 2024

Currently, it's possible to create an access grant that's meant to be used only with us-select-1 edge services (for example) and register it at auth.storjshare.io instead of auth.us-select-1.storjshare.io.

A simple idea that prevents misuse of access grants targeting different auth services is to

  1. make sure auth service is aware of the placement region identifies it's primarily intended for
  2. add an optional placement region identifier to access grants and make the client code sign it
  3. make auth reject registration requests of access grants not intended for it
  4. for backwards compatibility, all access grants without the identifier can still be registered at any auth

This won't resolve complex cases such as "created access grant for placement X, then added a new bucket with placement Y and placement X became something else" but it works for the simple case of misuse described above and by lack of evidence of true misuse patterns, I'd estimate that would cover 99% cases of misuse.

Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authservice edge Feature Request SOC2 Compliance - Edge Services storage/migration of data needs to be soc2 compliant
Projects
None yet
Development

No branches or pull requests

2 participants