Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Global Shortcut for Play/Pause optional #169

Open
ravero opened this issue Jun 1, 2022 · 6 comments
Open

Make Global Shortcut for Play/Pause optional #169

ravero opened this issue Jun 1, 2022 · 6 comments

Comments

@ravero
Copy link
Contributor

ravero commented Jun 1, 2022

Currently the app has mapped Command + Shift + Spacebar to Play/Pause. This is redudant with Media keys (on F8) and is also conflicting with another Keyboard shortcut that I have mapped for this.

I would like to ask for either adding this shortcut as a preference or make it customizable entirely. I've made a fork where I've disable this keyboard for my own usage, I'm thinking of adding a Preferences window that would allow having this setting on or off (maybe its a issue for others too). Let me know if you would be interested in have this as a PR for this project.

Regards.

@karthicraghupathi
Copy link

karthicraghupathi commented Jun 20, 2022

I'm having the same issue. I have that combination assigned to Moom so it's causing my music to start and stop whenever I resize a window.

It would be great if this shortcut was made optional as there is a dedicated media key for this option.

Authors / Maintainers, please consider accepting @ravero's solution as part of a PR #170.

@ysquaredd
Copy link

This also conflicts with the default 1password shortcut for me. I would rather keep the 1password shortcut and disable the play/pause since media keys are available.

@ollynevard
Copy link

This also conflicts with the default 1password shortcut for me. I would rather keep the 1password shortcut and disable the play/pause since media keys are available.

Same for me. I'd much rather keep the shortcut for 1password as I have media keys for play/pause. It would be great if the key bindings were configurable, or at least optional.

As it stands, I currently pause my music everytime I enter a password.

@ravero
Copy link
Contributor Author

ravero commented Aug 7, 2022

Well, there's a long time I have a PR opened with a solution for this issue. I have compiled my own version, I'm considering creating a fork of this project because it seems pretty much abandoned, so I can release an updated version.

@TimOliver
Copy link
Collaborator

I appreciate the vote of confidence, lads! 😅

Trying to work through the blockers in shipping a new release with the new PR included now!

@vittorius
Copy link

@TimOliver this issue still persists in 1.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants