-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the split pane machinery to Overview / Detail #14
Comments
Agreed. We’ve used “leading” and “trailing” for this in our Swift sample version. That has a bit of layout-y-ness to it though. |
Main / Detail? Works a bit better with Kotlin's class MasterDetailScreen private constructor(
val masterRendering: BackStackScreen<Any>,
val detailRendering: BackStackScreen<Any>? = null,
val selectDefault: (() -> Unit)? = null
) { Still not great. :/ |
Parent / Child? |
Found this in Learning Programming Using Visual Basic .NET:
|
Parent/child are so overloaded, that seems like it could be more confusing than anything. Especially in a sentence like "The ParentChildContainer has two child screens – one is the parent screen, and the other is the child screen." |
Yeah, nonstarter. Well so far I think I like Main better than Index |
The main screen is almost always a navigation screen, but there are probably too many exceptions to name it something navigation-related. |
Some ideas in this thread: https://twitter.com/zachklipp/status/1268646364625293312?s=20 |
From the Twitter thread, I like Overview / Detail a lot. |
I think the Detail terminology is pretty settled. So let's vote on the other one:
Please react on this message with your vote! |
One of the arguments for Primary/Secondary is that it opens the possibility for other screens, like Tertiary, etc. I personally am not a huge fan, since it's using very generic words to refer to a very specific layout pattern. |
I strongly dislike |
I like |
We've discussed offline, and reached a majority agreement on the terms |
Fixes the kotlin half of #1188.
Master / Detail is not great terminology.
The text was updated successfully, but these errors were encountered: