Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift] Pass workflow to WorkflowActions #139

Open
zach-klippenstein opened this issue Jan 27, 2020 · 0 comments
Open

[swift] Pass workflow to WorkflowActions #139

zach-klippenstein opened this issue Jan 27, 2020 · 0 comments
Labels
enhancement New feature or request swift

Comments

@zach-klippenstein
Copy link
Collaborator

It's come up a couple of times, at least in Kotlin, that WorkflowActions get the state of the current workflow but not its props. Since we consider props to be part of the workflow's overall "state", it seems unintuitive that we only pass part of that to actions.

The reason for not doing this was, initially, to discourage side effects from being performed in actions. However, we realized that is too restrictive (see this Slack discussion).

Note for Swift this means passing the Workflow value itself into the action, since there's no separate props type.

Swift version of square/workflow-kotlin#56.

@zach-klippenstein zach-klippenstein added the enhancement New feature or request label Jan 27, 2020
@rjrjr rjrjr transferred this issue from square/workflow May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request swift
Projects
None yet
Development

No branches or pull requests

2 participants