Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for cached WorkflowIdentifier in RenderTester #974

Open
steve-the-edwards opened this issue Mar 20, 2023 · 0 comments
Open

Account for cached WorkflowIdentifier in RenderTester #974

steve-the-edwards opened this issue Mar 20, 2023 · 0 comments
Labels
testing Related to test helpers.

Comments

@steve-the-edwards
Copy link
Contributor

After adding in caching for the Workflow Ids we may want to add in consideration of this to the RenderTester so that the ids of any children that are not used (since they are passed in via expectWorkflow) don't have their ids cached (or at least do so harmlessly).

Use case, we had a testRender where the Workflow-under-test had child workflows passed in as mocks. These mocks had cachedIdentifier set and accessed even though they shouldn't be used at all by the RenderTester.
@steve-the-edwards steve-the-edwards changed the title Account for cachedWorkflowIdentifier in RenderTester Account for cached WorkflowIdentifier in RenderTester Mar 20, 2023
@steve-the-edwards steve-the-edwards added the testing Related to test helpers. label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Related to test helpers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@steve-the-edwards