Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide percentile histogram metrics with Observability Api #794

Closed
kyle-a-wong opened this issue Sep 14, 2023 · 3 comments
Closed

Provide percentile histogram metrics with Observability Api #794

kyle-a-wong opened this issue Sep 14, 2023 · 3 comments
Labels
for: stackoverflow A question that's better suited to stackoverflow status: invalid An issue that we don't feel is valid

Comments

@kyle-a-wong
Copy link

With the new implementation of metrics using micrometer's observability api, there are no long percentile histogram metrics published. It would be nice for them to be included to preserve similar metrics that were provided in spring boot 2.7

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 14, 2023
@bclozel
Copy link
Member

bclozel commented Sep 14, 2023

I don't think percentile histograms were contributed by default previously. Did you configure something specific in the past to enable them?

I think you can still enable those on a per-metric basis (or for all at once) with "management.metrics.distribution.percentiles-histogram.your.metric=true" (or use the "all" metric name to match all).

See the Spring Boot reference docs and the configuration properties reference.

@bclozel bclozel added the status: waiting-for-feedback We need additional information before we can continue label Sep 14, 2023
@kyle-a-wong
Copy link
Author

kyle-a-wong commented Sep 15, 2023

Hi @bclozel , i responded to your comment on my SO post as well, but you can find the property and the enabling of histograms in AutoTimeProperties.java. The configuration to set would be management.graphql.autotime.percentiles-histogram=true. This is available for any metric provided by spring-boot-actuator

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 15, 2023
@bclozel
Copy link
Member

bclozel commented Sep 19, 2023

Answered in the original StackOverflow question.

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2023
@bclozel bclozel added status: invalid An issue that we don't feel is valid for: stackoverflow A question that's better suited to stackoverflow and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: stackoverflow A question that's better suited to stackoverflow status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

3 participants