Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: radio buttons on submit page #289

Open
corinneling opened this issue Oct 6, 2020 · 0 comments
Open

fix: radio buttons on submit page #289

corinneling opened this issue Oct 6, 2020 · 0 comments

Comments

@corinneling
Copy link

corinneling commented Oct 6, 2020

The radio buttons on the submit page must be in a radio group so that the radio buttons have a corresponding label. For more information check out Deque's page on form elements must have labels which includes instructions on how to fix the issue.

Do this by updating the _form.hbs file. The radio buttons and label can be found on lines 6 - 8. Note: make sure to keep all of the class names and other attributes the same

Suggestion:

  • Wrap the radio buttons in a <div> with the attribute role="radiogroup". Instead of this we could always wrap the radio buttons in a feildset with a legend, but with the <div role="radiogroup"> </div> we dont have to worry about any extra styles.
  • Also, instead of adding the text "Is your apprenticeship a paid opportunity?" in a <label>, we are going to treat it like a <legend>. So the final code will look something like this with the paragraph tag having an id attribute that matches the value of the aria-labelledby on the div
<div role="radiogroup" aria-labelledby="paid-opportunity">
   <p id="paid-opportunity">Is your apprenticeship a paid opportunity?</>
   <input type="radio">
   <input type="radio">
</div>

For more information on radios and radio groups checkout Deque's example

See screenshot of radio buttons on the submit page:
Apprentice_at-radio-buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants