-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaBlockService required if formats defined #2435
Comments
HI @mesiarm, can you explain why the format key should be optional ? |
There may be cases, when I want to choose it by programming logic or use full size. |
But I assume the data need to be required for people which doesn't have extra-programming-logic. Changing the field to optional will create an issue for them. Does adding an option to |
Yes, it would help |
PR welcomed then. |
Make format key always optional even if formats are defined.
Now it is:
'required' => \count($formatChoices) > 0,
It is unable to set some of images reference if formats are defined
The text was updated successfully, but these errors were encountered: