Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✨] feat: sitemap generator #353

Open
TheElegantCoding opened this issue Jan 11, 2024 · 5 comments
Open

[✨] feat: sitemap generator #353

TheElegantCoding opened this issue Jan 11, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@TheElegantCoding
Copy link

Describe the bug

i open this as an issue because i cant open a feature request, it will be nice that we can add support of a sitemap generator i don't know if this can be done in this repo or has o be a separate package

This is a reference of how a sitemap generatos work in astro

Your Example Website or App

none

Steps to Reproduce the Bug or Issue

none

Expected behavior

none

Screenshots or Videos

No response

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 91.1]

Additional context

No response

@Brendonovich
Copy link
Contributor

This is probably in the domain of SolidStart rather than the router

@TheElegantCoding
Copy link
Author

this is for solid and solid router not solid-start

@Brendonovich
Copy link
Contributor

Brendonovich commented Jan 23, 2024

I know you'd like this as a router feature, but I mention SolidStart as I'm not sure the router is capable enough to know the sitemap ahead of time.
Looking at Astro's sitemap plugin, it only works for routes with paths that are known at build time ie. fixed-path routes and dynamic routes that are statically generated with getStaticRoutes. Dynamic routes that are evaluated at runtime can't be included in a sitemap.
The router isn't in the position to know what routes are available at build time - it just knows the runtime routing schema. SolidStart on the other hand does know which routes are pre-rendered by crawling and explicit instruction.
Implementing it in SS would also make sitemaps work independent of which router you use, which is pretty cool.

@madaxen86
Copy link
Contributor

madaxen86 commented Feb 28, 2024

Have you tried to use a Vite plugin like:
https://github.com/jbaubree/vite-plugin-pages-sitemap

@TheElegantCoding
Copy link
Author

@madaxen86 not yet, but this issue is for a feature request in solid or solid-router, that can only be a temporary solution

@ryansolid ryansolid added the enhancement New feature or request label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants