Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trackpad tap events do not always work #942

Open
jaymakes11 opened this issue Feb 26, 2024 · 3 comments
Open

Trackpad tap events do not always work #942

jaymakes11 opened this issue Feb 26, 2024 · 3 comments

Comments

@jaymakes11
Copy link

What OS are you using (uname -a, or Windows version)?

Darwin MacBook-Pro.local 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000 arm64

What version Socket Runtime are you using?

0.5.4 (97fa3f7c)

What programming language are you using (C/C++/Go/Rust)?

JS (Node v20.11.0)

What did you expect to see and what you saw instead?

Expect taps (on macbook pro's built-in trackpad) to work as expected
Taps only work sometimes as expected

Created an isolated test case: https://github.com/jaymakes11/ssc-reproduce-tap-bug

Created a demo video in that repos README (watch with video's sound turned ON to hear the taps).

@heapwolf
Copy link
Member

I was able to reproduce, the bug seems to be that the first tap on something that should be tappable isn't getting recognized, but all subsequent taps are. I'll look into this more.

@jaymakes11
Copy link
Author

the bug seems to be that the first tap on something that should be tappable isn't getting recognized, but all subsequent taps are.

Just a note here that I'm somewhat consistently seeing it happen on the same element (without taping something else in between taps), though I don't think this was shown in my demo video.

@heapwolf
Copy link
Member

heapwolf commented Feb 26, 2024

what's also a bit interesting is that tap on body always responds.

document.body.addEventListener('click', function() {
  console.log('BODY TAP') // tap is reliable
})

UPDATE: It also looks like the pointer down event fires reliably on all taps.

incrementButton.addEventListener('pointerdown', function() {
  console.log('BUTTON TAP') // tap is reliable
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants