Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseRequest fails parsing an url with a no port number after ":" #501

Open
joeyh opened this issue Feb 10, 2023 · 0 comments
Open

parseRequest fails parsing an url with a no port number after ":" #501

joeyh opened this issue Feb 10, 2023 · 0 comments

Comments

@joeyh
Copy link
Contributor

joeyh commented Feb 10, 2023 

   ghci> parseRequest "https://datasets.datalad.org:/dbic/QA/.git/"
    *** Exception: InvalidUrlException "https://datasets.datalad.org:/dbic/QA/.git/" "Invalid port"

Compare this with the behavior of network-uri's parseURI, which accepts it. Also firefox, curl, and wget all support it.

My reading of RFC 1738 is that this url is not really valid. But Postel's law probably still applies more to URL parsing than it does to most things these days.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeyh