From 57b46385a91c52a8bf1da9780dededee5a96b75a Mon Sep 17 00:00:00 2001 From: Michele Caini Date: Mon, 16 Sep 2024 17:19:05 +0200 Subject: [PATCH] test: implicit noexcept-ness for dtors --- test/entt/core/any.cpp | 2 +- test/entt/entity/registry.cpp | 2 +- test/entt/entity/storage.cpp | 2 +- test/entt/locator/locator.cpp | 2 +- test/entt/meta/meta_any.cpp | 6 +++--- test/entt/meta/meta_data.cpp | 2 +- test/entt/meta/meta_func.cpp | 2 +- test/entt/meta/meta_type.cpp | 2 +- test/entt/resource/resource.cpp | 2 +- test/example/custom_identifier.cpp | 2 +- 10 files changed, 12 insertions(+), 12 deletions(-) diff --git a/test/entt/core/any.cpp b/test/entt/core/any.cpp index e8a6b6db08..c4cc68c2d3 100644 --- a/test/entt/core/any.cpp +++ b/test/entt/core/any.cpp @@ -24,7 +24,7 @@ struct tracker { tracker(const tracker &) = default; tracker &operator=(const tracker &) = delete; - ~tracker() noexcept { + ~tracker() { ++(*counter); } diff --git a/test/entt/entity/registry.cpp b/test/entt/entity/registry.cpp index c184c00b2a..4262018157 100644 --- a/test/entt/entity/registry.cpp +++ b/test/entt/entity/registry.cpp @@ -71,7 +71,7 @@ struct destruction_order { destruction_order(const destruction_order &) = delete; destruction_order &operator=(const destruction_order &) = delete; - ~destruction_order() noexcept { + ~destruction_order() { *ctx_check = *ctx_check && (registry->ctx().find() != nullptr); } diff --git a/test/entt/entity/storage.cpp b/test/entt/entity/storage.cpp index 7b855c320e..7dc999fe6d 100644 --- a/test/entt/entity/storage.cpp +++ b/test/entt/entity/storage.cpp @@ -39,7 +39,7 @@ struct update_from_destructor { return *this; } - ~update_from_destructor() noexcept { + ~update_from_destructor() { if(target != entt::null && storage->contains(target)) { storage->erase(target); } diff --git a/test/entt/locator/locator.cpp b/test/entt/locator/locator.cpp index 3a42d4f47f..f7709a2c1c 100644 --- a/test/entt/locator/locator.cpp +++ b/test/entt/locator/locator.cpp @@ -4,7 +4,7 @@ #include "../../common/config.h" struct base_service { - virtual ~base_service() noexcept = default; + virtual ~base_service() = default; virtual int invoke(int) = 0; }; diff --git a/test/entt/meta/meta_any.cpp b/test/entt/meta/meta_any.cpp index 738c96475b..762d6e17de 100644 --- a/test/entt/meta/meta_any.cpp +++ b/test/entt/meta/meta_any.cpp @@ -34,7 +34,7 @@ struct empty { empty(const empty &) = default; empty &operator=(const empty &) = default; - virtual ~empty() noexcept { + virtual ~empty() { ++destructor_counter; } @@ -53,7 +53,7 @@ struct fat: empty { fat(double v1, double v2, double v3, double v4) : value{v1, v2, v3, v4} {} - ~fat() noexcept override = default; + ~fat() override = default; fat(const fat &) = default; fat &operator=(const fat &) = default; @@ -74,7 +74,7 @@ struct unmanageable { unmanageable() : value{std::make_unique(3)} {} - ~unmanageable() noexcept = default; + ~unmanageable() = default; unmanageable(const unmanageable &) = delete; unmanageable(unmanageable &&) = delete; diff --git a/test/entt/meta/meta_data.cpp b/test/entt/meta/meta_data.cpp index fc3fd48315..ceb54a9a76 100644 --- a/test/entt/meta/meta_data.cpp +++ b/test/entt/meta/meta_data.cpp @@ -16,7 +16,7 @@ #include "../../common/meta_traits.h" struct base { - virtual ~base() noexcept = default; + virtual ~base() = default; static void destroy(base &) { ++counter; diff --git a/test/entt/meta/meta_func.cpp b/test/entt/meta/meta_func.cpp index 7320c656ff..46e858d269 100644 --- a/test/entt/meta/meta_func.cpp +++ b/test/entt/meta/meta_func.cpp @@ -15,7 +15,7 @@ struct base { base() = default; - virtual ~base() noexcept = default; + virtual ~base() = default; void setter(int v) { value = v; diff --git a/test/entt/meta/meta_type.cpp b/test/entt/meta/meta_type.cpp index 983a77df56..9b20fc68ab 100644 --- a/test/entt/meta/meta_type.cpp +++ b/test/entt/meta/meta_type.cpp @@ -39,7 +39,7 @@ struct derived: base { }; struct abstract { - virtual ~abstract() noexcept = default; + virtual ~abstract() = default; virtual void func(int) {} void base_only(int) {} diff --git a/test/entt/resource/resource.cpp b/test/entt/resource/resource.cpp index d0f7beb5ab..a8f057aabc 100644 --- a/test/entt/resource/resource.cpp +++ b/test/entt/resource/resource.cpp @@ -6,7 +6,7 @@ #include "../../common/linter.hpp" struct base { - virtual ~base() noexcept = default; + virtual ~base() = default; [[nodiscard]] virtual const entt::type_info &type() const noexcept { return entt::type_id(); diff --git a/test/example/custom_identifier.cpp b/test/example/custom_identifier.cpp index 81b12da9f1..a9b1ebb43b 100644 --- a/test/example/custom_identifier.cpp +++ b/test/example/custom_identifier.cpp @@ -10,7 +10,7 @@ struct entity_id final { constexpr entity_id(entity_type value = null) noexcept : entt{value} {} - ~entity_id() noexcept = default; + ~entity_id() = default; constexpr entity_id(const entity_id &other) = default; constexpr entity_id(entity_id &&other) noexcept = default;