ParentFolder should not submit

[gmkll]

Except DOM-Reloading with XHR-Request a Full-Page-Reload is triggered with current code

$('#parentfolder').click(function() { getFolderInfo(currentpath); } );

Returnig false is required to avoid this...

$('#parentfolder').click(function() { getFolderInfo(currentpath); return false; } );

[psolom]

You are right, the bug exists. This repo isn't maintained currently. But this bug is already fixed at my repo: Rich Filemanager, which has a lot of fixes, improvements and new features. Here is the changelog.

[gmkll]

Hi, thanks for pointing me to Rich FileManager! I just finished migrating an old Simogeo-Filemanager. In my forked scripts/filemanager.js code I started using async ajax calls, e.g. loading config files and elsewhere, but not completely up to now) and cleaned up a little bit the global space... , Sync calls are really deprecated! I am using JSP connector, which I updated as well, but not included in my git repo because of specific changes and cleaning work I have to do, which I have not done yet ..

[psolom]

Cool! Maybe you would like to become a maintainer of JSP connector in my repo. The API is changed a bit due to client-side modifications. Check the roadmap to be aware of planned and implemented features. By the way a developer for Java backend has joined recently.

[gmkll]

Hi, I uploaded the Java changes into my repo and made a Pull request #505, where you can cherry pick, what you want. Be aware, that FileManager.java requires Java 7 as it uses java.nio.

[psolom]

Could you make the same PR to RichFilemanager repo?

[psolom]

But anyway it will require some refactoring and polishing, because of a number of changes in my repo. Will you be able to test and adjust Java connector after I will apply it to my repo.

[psolom]

Since I'm not familiar with Java I need your help to make the Java connector work. And keep in mind that this repo is weakly supported, so if you want to help others to get Java connector worked together with a new features, then I would suggest you to migrate to RichFilemanager repo. It was agreed with simogeo - maintainer of the current repo.

[gmkll]

I´ll give it a try. I probably have to merge into RichFileManager filemanager.js, Many things seem to work, What´s changed, is that Preview property is now Thumbnail, although PReview seems to exist still. Rename and Select are ok, Upload not yet...

[psolom]

Yeah, there were a lot of changes. Concerning to Preview and Thumbnail an issue was found recently. I'm going to handle it, perhaps some modifications will be made. You'd better suspend on that. But the other stuff is good.

[gmkll]

I have forked RichFileManager repo and managed to apply the changes I did (as in PullRequest #505) and fixed the download support in Java connector. I also added an abstract class (to be reused in both Filemanagers), and just moved only the methods specific to the new RichFM (which is referenced in filemanager.jsp). Unfortunately I see for the moment no easy way to implement the upload features, so I´ll stick with old simogeo FM, where I updated my changes accordingly (yet in forks). Though I could provide pull requests for both..

[psolom]

That is great! I will apply your PR to the current repo. Could I expect you to implement the upload features for RichFilemanager and create PR soon?

[gmkll]

I updated and finshed all, last step was moving data holder variable to local scope again. I merged the last changes from your repo, but nevertheless some major reordering especially at the beginning and at the end of filemanager.js could not be avoided and should be reviewed. Check the PR.

[gmkll]

I´ll may work on it soon (it seems textarea html content type is not required for replace?). In the current PR I have added an old check for fileRoot, which I should remove, as it seems not required any more...

[gmkll]

I tested upload and replace file(s), which seem to work now, although fileTree refresh seems not .. another TODO. I committed an update .

[simogeo]

RichFilemanager is now the reference ! Happy to see that more and more people are getting involved.