Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The aac files behind voice messages are missing length information #13720

Open
4 tasks done
NetSysFire opened this issue Sep 30, 2024 · 0 comments
Open
4 tasks done

The aac files behind voice messages are missing length information #13720

NetSysFire opened this issue Sep 30, 2024 · 0 comments

Comments

@NetSysFire
Copy link
Contributor


Bug description

This was discovered to be a bug in the android app in signalapp/Signal-Desktop#7036.
The aac files that get produced by the android app have no length information, resulting in the application guessing the length. This is inaccurate and leads to the reported length always being shorter than the actual length. Trying to play an affected voice message with e.g mpv has the exact same issue like signal desktop but with a helpful warning:

[ffmpeg/demuxer] aac: Estimating duration from bitrate, this may be inaccurate

For a yet unknown reason they do display fine on the android app though. Signal desktop produces entirely unaffected voice messages because it uses the mp3 format, not aac.

Steps to reproduce

  1. Record a voice message that is at least 30 seconds long. The longer the duration, the higher the inaccuracy.
  2. Send it to someone that has signal desktop.

Actual result: With a file that is actually 2 minutes and 29 seconds long it is reported as 2 minutes 18 seconds long on signal desktop.
Expected result: The file has metadata or something in it so the length does not have to be guessed and it reports 2 minutes and 29 seconds in this case.

Screenshots

Voice message as displayed in signal desktop:
image

The very same voice message as displayed on my linked Android phone:
image

Device info

Device: Various, including Pixel 5 (with lineageos) and recent Samsung A-something.
Android version: Various, sender has 14.
Signal version: 7.17.6

Link to debug log

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant