From 40b1a49aa7ba907a33c7a8e41b0df767d18e1cdc Mon Sep 17 00:00:00 2001 From: Naggafin <7529169+Naggafin@users.noreply.github.com> Date: Thu, 31 Aug 2023 18:12:16 -0400 Subject: [PATCH] fixed bug where `extra_context` was being truncated before being passed to `super().change_view()`; updated html templates to be compatible with django-fastdev validation --- django_admin_search/admin.py | 3 ++- .../templates/admin/custom_search_form.html | 8 +++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/django_admin_search/admin.py b/django_admin_search/admin.py index f11a650..2d1e8ad 100644 --- a/django_admin_search/admin.py +++ b/django_admin_search/admin.py @@ -31,11 +31,12 @@ def changelist_view(self, request, extra_context=None): """ Append custom form to page render """ + extra_context = extra_context or {} if hasattr(self, 'search_form'): self.advanced_search_fields = {} self.search_form_data = self.search_form(request.GET.dict()) self.extract_advanced_search_terms(request.GET) - extra_context = {'asf': self.search_form_data} + extra_context.update({'asf': self.search_form_data}) return super().changelist_view(request, extra_context=extra_context) diff --git a/django_admin_search/templates/admin/custom_search_form.html b/django_admin_search/templates/admin/custom_search_form.html index bbc09b5..4b1c66f 100644 --- a/django_admin_search/templates/admin/custom_search_form.html +++ b/django_admin_search/templates/admin/custom_search_form.html @@ -23,9 +23,11 @@ {{ full_result_count }} total{% endblocktrans %}{% else %}{% trans "Show all" %}{% endif %}) {% endif %} - {% for pair in cl.params.items %} - {% if pair.0 != search_var %}{% endif %} - {% endfor %} + {% if cl.params %} + {% for pair in cl.params.items %} + {% if pair.0 != search_var %}{% endif %} + {% endfor %} + {% endif %}
{% block modal_search_button %}