Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PassthroughBehavior and ContentHandling configuration options for SQS #211

Open
haykgh opened this issue Jul 31, 2024 · 0 comments
Open

Comments

@haykgh
Copy link

haykgh commented Jul 31, 2024

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

For SQS service, PassthroughBehavior option has 'NEVER' hardcoded value and ContentHandling option ignored. This patch aimed to fix this gap. Please add it to next release.

Here is the diff that solved my problem:

diff --git a/node_modules/serverless-apigateway-service-proxy/lib/package/sqs/compileMethodsToSqs.js b/node_modules/serverless-apigateway-service-proxy/lib/package/sqs/compileMethodsToSqs.js
index c9d0cc8..9c556b3 100644
--- a/node_modules/serverless-apigateway-service-proxy/lib/package/sqs/compileMethodsToSqs.js
+++ b/node_modules/serverless-apigateway-service-proxy/lib/package/sqs/compileMethodsToSqs.js
@@ -75,7 +75,16 @@ module.exports = {
       )
       integration.RequestTemplates = { 'application/json': '{statusCode:200}' }
     } else {
-      integration.PassthroughBehavior = 'NEVER'
+      if ('passThrough' in http.request) {
+        integration.PassthroughBehavior = http.request.passThrough
+      } else {
+        integration.PassthroughBehavior = 'NEVER'
+      }
+
+      if ('contentHandling' in http.request) {
+        integration.ContentHandling = http.request.contentHandling
+      }
+
       integration.RequestParameters = _.merge(
         {
           'integration.request.header.Content-Type': "'application/x-www-form-urlencoded'"

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant