Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinesis selectionPattern wrong, causing deployment failure #205

Open
quitedensepoint opened this issue Aug 18, 2023 · 0 comments
Open

Kinesis selectionPattern wrong, causing deployment failure #205

quitedensepoint opened this issue Aug 18, 2023 · 0 comments

Comments

@quitedensepoint
Copy link

The selectionPattern used in the code for specifically the Kinesis response templates appears to be using an incorrect number type when it should be a string. It is not overridable in the serverless.yml file. To get my team unblocked here, I had to fork this package internally with a fix.

To reproduce the problem, just attempt to deploy any Kinesis -> Lambda integration with serverless.yml code such as the following:

custom:
  apiGatewayServiceProxies:
    - kinesis:
        path: /myPath
        method: post
        action: PutRecord
        streamName: { Ref: 'MyStream' }

For full disclosure, I was deploying only to LocalStack 2.2 at the time instead of real AWS, so it's possible LocalStack is more strict than AWS here. But the AWS documentation definitely states that the expected type is a string:
Docs Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant