Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default policy for putting S3 objects is insecure #135

Open
robgott opened this issue Aug 25, 2021 · 0 comments
Open

default policy for putting S3 objects is insecure #135

robgott opened this issue Aug 25, 2021 · 0 comments

Comments

@robgott
Copy link

robgott commented Aug 25, 2021

Currently authenticated-read is used by default when a PUT/POST request is made using the S3 proxy, this is insecure as anyone with an AWS account can read the resulting file. Defualt should be private or not setting the header by default.

serverless-apigateway-service-proxy/lib/package/s3/compileMethodsToS3.js

Line 94 in 1ed7b85

'integration.request.header.x-amz-acl': "'authenticated-read'",

related to #124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robgott