Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics arguments to runs view subcommand do not change output #409

Open
robsyme opened this issue May 14, 2024 · 2 comments
Open

Metrics arguments to runs view subcommand do not change output #409

robsyme opened this issue May 14, 2024 · 2 comments

Comments

@robsyme
Copy link
Member

robsyme commented May 14, 2024

Adding any of the metrics command to the runs view command do not append any new metrics:

$ tw -o json runs view --id 5CTeD42c9cFCRo \
  | md5sum-lite
eb9a64c5557ee2894a363444c435c175 -
$ tw -o json runs view --id 5CTeD42c9cFCRo \
  --metrics-memory \
  --metrics-cpu \
  --metrics-time \
  --metrics-io \
  | md5sum-lite
eb9a64c5557ee2894a363444c435c175  -
@robsyme
Copy link
Member Author

robsyme commented May 14, 2024

The cli indicates that these metrics args are to be applied at the "tw runs view" level (as shown above), but perhaps they are supposed to be applied at the "metrics" subcommand. If so, we have the same problem:

$ tw -o json runs view --id 5CTeD42c9cFCRo metrics | jq '. | keys[]'
"metricsCpu"
"metricsIo"
"metricsMemory"
"metricsTime"
tw -o json runs view --id 5CTeD42c9cFCRo --metrics-cpu metrics | jq '. | keys[]'
"metricsCpu"
"metricsIo"
"metricsMemory"
"metricsTime"

@jordeu
Copy link
Member

jordeu commented May 14, 2024

I'm unsure why these --metrics-... were added; they're never used.

Maybe what you are looking for is the --type option in metrics subcommand:

-t, --type=<type>[,<type>...]            Process metric types separated by comma: cpu, mem, time, io [default: displays all].

Example:

$ tw runs view --id 2m2ZyQ076oUNL0 metrics --type mem 
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants