Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server::run should return ! (never type) #1072

Open
ia0 opened this issue Oct 19, 2023 · 0 comments
Open

Server::run should return ! (never type) #1072

ia0 opened this issue Oct 19, 2023 · 0 comments
Labels
feature New feature or request

Comments

@ia0
Copy link

ia0 commented Oct 19, 2023

Is your feature request related to a problem? Please describe.
One has to write unreachable!() after server.run().await.

Describe the solution you'd like
I want Server::run() to return ! (never type):

pub async fn run(self, addr: impl Into<SocketAddr>) -> !;

Or, if run() may actually return (although its documentation says it doesn't), then update the documentation to explain when it can return.

Describe alternatives you've considered
Writing unreachable!() manually.

@ia0 ia0 added the feature New feature or request label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant