-
Notifications
You must be signed in to change notification settings - Fork 3
Possible misuse of ioutil.TempDir
#2
Comments
ioutil.TempDir
should use the system default temporary directoryioutil.TempDir
To be fair, this will only be used for testing and needs to be in a place where we can easily examine the outcome in case of failure. Alternatively we could place this in the project folder (pwd) as a hidden .sdkman directory. wdyt? |
I've created the #3 to run tests successfully on windows.
System's default temporary directory (used by
I think writing something in the source tree is a bad thing. |
Sure, but I also think that this is a lot of extra boilerplate, complexity and duplication for something that can be solved in a far simpler way. Shall we move these discussions to our Gitter channel before continuing? |
@marc0der OK. Continuing in the Gitter channel… |
Don't hardcode
/tmp
. This will cause unexpected test failure on Windows.# I'll check it on windows later. (at this time, no Windows station near me 😢)
# Appended
Under windows environment
ioutil.TempDir("/tmp", ...
cause errorThe text was updated successfully, but these errors were encountered: