From 7c411e67ce2a438931fb5f03da025e2d5a99d45c Mon Sep 17 00:00:00 2001 From: Mustafa BALCI Date: Thu, 12 Sep 2024 17:31:56 +0300 Subject: [PATCH 1/2] Renamed $response to $responseClass for better clarity --- src/Traits/Responses/HasCustomResponses.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Traits/Responses/HasCustomResponses.php b/src/Traits/Responses/HasCustomResponses.php index 0100ab7f..66d18f25 100644 --- a/src/Traits/Responses/HasCustomResponses.php +++ b/src/Traits/Responses/HasCustomResponses.php @@ -7,13 +7,13 @@ trait HasCustomResponses { /** - * Specify a default response. + * Specify a default response class. * * When null or an empty string, the response on the sender will be used. * * @var class-string<\Saloon\Http\Response>|null */ - protected ?string $response = null; + protected ?string $responseClass = null; /** * Resolve the custom response class @@ -22,6 +22,6 @@ trait HasCustomResponses */ public function resolveResponseClass(): ?string { - return $this->response ?? null; + return $this->responseClass ?? null; } } From 234c15122491d6f8875eb00e9b0d648dd1bfd049 Mon Sep 17 00:00:00 2001 From: Mustafa BALCI Date: Thu, 26 Sep 2024 16:22:21 +0300 Subject: [PATCH 2/2] HasCustomResponses trait changed to HasResponseClass --- src/Http/Connector.php | 4 ++-- src/Http/Request.php | 4 ++-- .../{HasCustomResponses.php => HasResponseClass.php} | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) rename src/Traits/Responses/{HasCustomResponses.php => HasResponseClass.php} (95%) diff --git a/src/Http/Connector.php b/src/Http/Connector.php index 18b49c8d..a45b150b 100644 --- a/src/Http/Connector.php +++ b/src/Http/Connector.php @@ -14,7 +14,7 @@ use Saloon\Traits\Connector\SendsRequests; use Saloon\Traits\Auth\AuthenticatesRequests; use Saloon\Traits\RequestProperties\HasTries; -use Saloon\Traits\Responses\HasCustomResponses; +use Saloon\Traits\Responses\HasResponseClass; use Saloon\Traits\Request\CreatesDtoFromResponse; use Saloon\Traits\RequestProperties\HasRequestProperties; @@ -23,7 +23,7 @@ abstract class Connector use CreatesDtoFromResponse; use AuthenticatesRequests; use HasRequestProperties; - use HasCustomResponses; + use HasResponseClass; use ManagesExceptions; use HandlesPsrRequest; use HasMockClient; diff --git a/src/Http/Request.php b/src/Http/Request.php index 111c428b..cb551ee0 100644 --- a/src/Http/Request.php +++ b/src/Http/Request.php @@ -15,7 +15,7 @@ use Saloon\Traits\ManagesExceptions; use Saloon\Traits\Auth\AuthenticatesRequests; use Saloon\Traits\RequestProperties\HasTries; -use Saloon\Traits\Responses\HasCustomResponses; +use Saloon\Traits\Responses\HasResponseClass; use Saloon\Traits\Request\CreatesDtoFromResponse; use Saloon\Traits\RequestProperties\HasRequestProperties; @@ -24,7 +24,7 @@ abstract class Request use CreatesDtoFromResponse; use AuthenticatesRequests; use HasRequestProperties; - use HasCustomResponses; + use HasResponseClass; use ManagesExceptions; use HandlesPsrRequest; use HasMockClient; diff --git a/src/Traits/Responses/HasCustomResponses.php b/src/Traits/Responses/HasResponseClass.php similarity index 95% rename from src/Traits/Responses/HasCustomResponses.php rename to src/Traits/Responses/HasResponseClass.php index 66d18f25..0e0acbb4 100644 --- a/src/Traits/Responses/HasCustomResponses.php +++ b/src/Traits/Responses/HasResponseClass.php @@ -4,7 +4,7 @@ namespace Saloon\Traits\Responses; -trait HasCustomResponses +trait HasResponseClass { /** * Specify a default response class.