Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

Should there be away to enable logging? #4

Open
stsquad opened this issue Feb 17, 2021 · 3 comments
Open

Should there be away to enable logging? #4

stsquad opened this issue Feb 17, 2021 · 3 comments

Comments

@stsquad
Copy link

stsquad commented Feb 17, 2021

I guess this might be a wider policy question but when implementing a new daemon should we have a way to enable logging in the backend crate. At the moment I'm stuck trying to diagnose where in the vhost-user sequence something is missing by using gdb. Perhaps we should use log! macros so debug builds can be more verbose if required?

@glitzflitz
Copy link

+1. I had to manually add debug! macro calls for debugging

@slp
Copy link
Collaborator

slp commented Feb 25, 2021

This is a question that affects all rust-vmm crates and has already popped up a couple times. We could perhaps bring this to the next rust-vmm meeting to see if we can reach an project-wide agreement about it.

@andreeaflorescu
Copy link
Member

Good idea! Let's chat about it at the next rust-vmm sync. In the vmm-reference we're going to try logging with the log crate as we've been also using it in Firecracker and is turns out to be very flexible. Other log crates are built on top so it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants