Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow controlling of the maximum queue size for daemons #202

Open
stsquad opened this issue Sep 2, 2022 · 2 comments
Open

Allow controlling of the maximum queue size for daemons #202

stsquad opened this issue Sep 2, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@stsquad
Copy link
Collaborator

stsquad commented Sep 2, 2022

This came up with the Gunyah integration testing with CrosVM. As their implementation has a fairly small amount of memory in the shared memory portion they couldn't fit the QUEUE_SIZE queue in it. This was solved with a local patch for the demo but obviously it would be nice to control this via an option/config.

@vireshk
Copy link
Collaborator

vireshk commented Dec 8, 2022

@stsquad Do you have the patch that fixes it ?

@stsquad
Copy link
Collaborator Author

stsquad commented Dec 8, 2022

I think they just hardcoded it for the purposes of the demo.

@stefano-garzarella stefano-garzarella added the enhancement New feature or request label Sep 27, 2023
@stefano-garzarella stefano-garzarella added the good first issue Good for newcomers label Sep 27, 2023
dorjoy03 added a commit to dorjoy03/vhost-device that referenced this issue Jul 8, 2024
The vring queue size was hardcoded to 256 which is problematic for
vsock devices that use a larger queue size. For example, when using
vhost-device-vsock with QEMU's vhost-user-vsock-device, the message
to set the vring queue size to 1024 causes an "InvalidParameter"
error from vhost-device-vsock. Making the queue size configurable
via an option makes it easy to use vhost-device-vsock where a larger
queue size is required.

The default queue size has also been increased to 1024.

Fixes: rust-vmm#202

Signed-off-by: Dorjoy Chowdhury <[email protected]>
dorjoy03 added a commit to dorjoy03/vhost-device that referenced this issue Jul 8, 2024
The vring queue size was hardcoded to 256 which is problematic for
vsock devices that use a larger queue size. For example, when using
vhost-device-vsock with QEMU's vhost-user-vsock-device, the message
to set the vring queue size to 1024 causes an "InvalidParameter"
error from vhost-device-vsock. Making the queue size configurable
via an option makes it easy to use vhost-device-vsock where a larger
queue size is required.

The default queue size has also been increased to 1024.

Fixes: rust-vmm#202

Signed-off-by: Dorjoy Chowdhury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants