Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary_cast: core::ffi::c_* cases #13494

Open
ojeda opened this issue Oct 3, 2024 · 0 comments
Open

unnecessary_cast: core::ffi::c_* cases #13494

ojeda opened this issue Oct 3, 2024 · 0 comments
Labels
C-bug Category: Clippy is not doing the correct thing I-false-negative Issue: The lint should have been triggered on code, but wasn't

Comments

@ojeda
Copy link
Contributor

ojeda commented Oct 3, 2024

Summary

unnecessary_cast's does not cover some cases around core::ffi::c_* types that it could.

Lint Name

unnecessary_cast

Reproducer

I tried this code:

let x = 42;
let _ = x as core::ffi::c_int as core::ffi::c_int;

I expected to see this happen: lint triggers (e.g. "warning: casting to the same type is unnecessary (core::ffi::c_int -> core::ffi::c_int)").

Instead, this happened: lint does not trigger.

Version

rustc 1.83.0-nightly (18b1161ec 2024-10-02)
binary: rustc
commit-hash: 18b1161ec9eeab8927f91405bca0ddf59a4a26c9
commit-date: 2024-10-02
host: x86_64-unknown-linux-gnu
release: 1.83.0-nightly
LLVM version: 19.1.0

@ojeda ojeda added C-bug Category: Clippy is not doing the correct thing I-false-negative Issue: The lint should have been triggered on code, but wasn't labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing I-false-negative Issue: The lint should have been triggered on code, but wasn't
Projects
None yet
Development

No branches or pull requests

1 participant