Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra padding on simple form fields leads to inconsistencies #979

Open
h-m-m opened this issue Jun 26, 2021 · 1 comment
Open

Extra padding on simple form fields leads to inconsistencies #979

h-m-m opened this issue Jun 26, 2021 · 1 comment
Labels
design Type: Bug Something isn't working

Comments

@h-m-m
Copy link
Collaborator

h-m-m commented Jun 26, 2021

On various form pages, 2 ems of padding combined with inline-flex leads to squished-looking inputs at smaller breakpoints with a bunch of space off the the side unused. Also, at small enough mobile breakpoints, it'd be good for these fields to stack instead of remaining side-by-side.

With padding:
Screen Shot 2021-06-26 at 10 52 49 AM
(also the asterisk denoting "required" gets orphaned at the end of a line break)

Removing the padding without any other changes isn't great, though:
Screen Shot 2021-06-26 at 10 56 55 AM
(this screenshot taken at the same window width as the first screenshot — notice that it uses extra width on the right)

We also use that padding on the admin community resource page to give it nice looking columns, so this padding isn't something we can remove without making adjustments wherever it's used.

With padding:
Screen Shot 2021-06-26 at 10 49 48 AM

Without padding:
Screen Shot 2021-06-26 at 10 49 57 AM

(thanks @exbinary and @Connieh1 for feedback and suggestions on this issue)

@h-m-m
Copy link
Collaborator Author

h-m-m commented Jun 26, 2021

Related: #964 and #483

@solebared solebared added Type: Bug Something isn't working design labels Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants