Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unknown go version with FreeBSD, amd64 #11

Open
jeffallen opened this issue Feb 19, 2019 · 0 comments · May be fixed by #17
Open

unknown go version with FreeBSD, amd64 #11

jeffallen opened this issue Feb 19, 2019 · 0 comments · May be fixed by #17

Comments

@jeffallen
Copy link

Using the latest goversion, and a binary cross-compiled from MacOS using "GOOS=freebsd GOARCH=amd64 GO111MODULE=on go build", I get this:

icsil1noteb238:conode jallen$ goversion -d ./conode-v3.0.0-check/conode.FreeBSD.amd64 
data @0x458680: 488d7708488b3fe9d4c6ffffcccccccc
data: 488d7708488b3fe9d4c6ffffcccccccc488b7c24088b7424108b5424144c8b54
no match (0) 0x458680 [e9 1ff00 ff00 ff00 2ff00 cc cc cc] 488d7708488b3fe9d4c6ffffcccccccc488b7c24088b7424108b5424144c8b54
no match (1) 0x458680 [48 8d 74 24 8 48 8b 3c 24 48 8d 5 1ff00 ff00 ff00 2ff00 ff e0] 488d7708488b3fe9d4c6ffffcccccccc488b7c24088b7424108b5424144c8b54
no match (2) 0x458680 [48 8d 74 24 8 48 8b 3c 24 b8 1ff00 ff00 ff00 ff00 ff e0] 488d7708488b3fe9d4c6ffffcccccccc488b7c24088b7424108b5424144c8b54
no match (3) 0x458680 [48 8b 3c 24 48 8d 74 24 8 e9 1ff00 ff00 ff00 2ff00 cc cc] 488d7708488b3fe9d4c6ffffcccccccc488b7c24088b7424108b5424144c8b54
no match (4) 0x458680 [4c 8d 5 ff00 ff00 ff00 ff00 48 8d d ff00 ff00 ff00 ff00 48 8d 3d 1ff00 ff00 ff00 2ff00 ff 15] 488d7708488b3fe9d4c6ffffcccccccc488b7c24088b7424108b5424144c8b54
no match (5) 0x458680 [54 49 c7 c0 ff00 ff00 ff00 ff00 48 c7 c1 ff00 ff00 ff00 ff00 48 c7 c7 1ff00 ff00 ff00 ff00] 488d7708488b3fe9d4c6ffffcccccccc488b7c24088b7424108b5424144c8b54
no match (6) 0x458680 [48 8d 5 1ff00 ff00 ff00 2ff00 ff e0] 488d7708488b3fe9d4c6ffffcccccccc488b7c24088b7424108b5424144c8b54
no match (7) 0x458680 [b8 1ff00 ff00 ff00 ff00 ff e0] 488d7708488b3fe9d4c6ffffcccccccc488b7c24088b7424108b5424144c8b54
no match (8) 0x458680 [e9 1ff00 ff00 ff00 2ff00 cc cc cc] 488d7708488b3fe9d4c6ffffcccccccc488b7c24088b7424108b5424144c8b54
no match (9) 0x458680 [48 89 f8 48 89 f3 48 83 ec 27 48 83 e4 f0 48 89 44 24 10 48 89 5c 24 18] 488d7708488b3fe9d4c6ffffcccccccc488b7c24088b7424108b5424144c8b54
./conode-v3.0.0-check/conode.FreeBSD.amd64 unknown Go version

Same problem with linux/arm:

icsil1noteb238:conode jallen$ goversion ./conode-v3.0.0-check/conode*
./conode-v3.0.0-check/conode.Darwin.x86_64 go1.11.5
./conode-v3.0.0-check/conode.FreeBSD.amd64 unknown Go version
./conode-v3.0.0-check/conode.Linux.armv7l unknown Go version
./conode-v3.0.0-check/conode.Linux.x86_64 go1.11.5
./conode-v3.0.0-check/conode.exe go1.11.5
FiloSottile added a commit to FiloSottile/goversion that referenced this issue Dec 15, 2020
@FiloSottile
goversion: rewrite on top of cmd/go/internal/version
967a33b 
Imported the cmd/go/internal/version implementation at
c32140fa94cfc51a2152855825f57e27ae3ba133, and restored Symbols and
TextRange to implement the gccgo and crypto checks.

It looks like the amd64 matching had broken, but it should be more
stable to just track what we do upstream with minimal modifications, so
I replaced the core mechanism rather than fixing the matcher.

Fixes rsc#14
Fixes rsc#12
Fixes rsc#11
Fixes rsc#7
Closes rsc#13
Closes rsc#9
@FiloSottile FiloSottile linked a pull request Dec 15, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

goversion: rewrite on top of cmd/go/internal/version FiloSottile/goversion
1 participant
@jeffallen