Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Improve StringStream handling #36

Open
3 tasks
dabonnie opened this issue Dec 10, 2019 · 3 comments
Open
3 tasks

Improve StringStream handling #36

dabonnie opened this issue Dec 10, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dabonnie
Copy link
Contributor

dabonnie commented Dec 10, 2019

Description

As done in #28, istringstream handling should throw an exception, rather than relying on nested if statements.

Test Plan

  • Manual testing
  • Unit test for new classes

Documentation Plan

  • update class documentation with throws

Release Plan

  • check in PR

Acceptance Criteria

  • Code has been implemented, reviewed and merged.
  • Test plan has been completed
  • Release plan has been completed

Once all above items are checked, this story can be closed.

@dabonnie dabonnie added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 10, 2019
@zmichaels11
Copy link

For context:

 std::stringstream ss
 ss.exceptions(std::ios::failbit | std::ios::badbit);
 // operations on ss go here

@emersonknapp emersonknapp added the enhancement New feature or request label Mar 9, 2020
@zmichaels11
Copy link

It doesn't look like this story is relevant anymore since there is no branching in any code using stringstream.
https://github.com/ros-tooling/system_metrics_collector/search?q=stringstream&unscoped_q=stringstream

@dabonnie
Copy link
Contributor Author

It doesn't look like this story is relevant anymore since there is no branching in any code using stringstream.
https://github.com/ros-tooling/system_metrics_collector/search?q=stringstream&unscoped_q=stringstream

Updated description, should be istringstream handling.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants